Firefox code review update

Effective immediately, there are a number of changes in the Firefox review process. Most notably, there are a lot more reviewers who can share the load, including Seth Spitzer who is now a module peer. Dietrich Ayala, Simon Bünzli, Tony Chang, Myk Melez, Robert Sayre, Benjamin Smedberg, and Robert Strong are now officially appropriate reviewers for various sub-modules within the app code (please see the linked document).

Just as importantly, there is now a formal requirement for unit testing. However, much of the window-level testing will depend on bug 375469, so in the meantime we should be making liberal use of in-testsuite? to flag bugs that we have to go back and get tests for. This should be limited to UI-level fixes, components and helper methods should get appropriate tests with the patch. Please talk to me if you have questions about this change, which now officially follows the lead of toolkit.

_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_
_

2 Comments

  1. RyanVM says:

    Vlad is listed as a peer but isn’t assigned to any sub-modules?

  2. Mike says:

    Yep, vlad’s a pretty strong generalist, he isn’t as active as he has been in the past, but his review is welcome if he has time to do one.

Leave a Reply